Skip to content

MOBILEWEBVIEW-6: JS Mobile bridge#671

Merged
enotniy merged 5 commits intomission/webview-inappfrom
feature/MOBILEWEBVIEW-6
Feb 3, 2026
Merged

MOBILEWEBVIEW-6: JS Mobile bridge#671
enotniy merged 5 commits intomission/webview-inappfrom
feature/MOBILEWEBVIEW-6

Conversation

@enotniy
Copy link
Collaborator

@enotniy enotniy commented Feb 2, 2026

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a JavaScript mobile bridge for WebView-based in-app messages, enabling bidirectional communication between JavaScript and native Android code using a request/response pattern.

Changes:

  • Introduced BridgeMessage sealed class hierarchy with Request, Response, and Error types for structured communication
  • Implemented WebViewActionHandlers to manage synchronous and asynchronous action handlers
  • Added BridgeMessageValidator to validate incoming bridge messages
  • Refactored WebViewInAppViewHolder to use the new bridge communication pattern with pending response tracking

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
WebViewAction.kt Defines bridge message types, action enum, and handler classes for WebView communication
BridgeMessageValidator.kt Validates bridge messages for required fields and supported values
WebViewInAppViewHolder.kt Refactored to use new bridge pattern with action handlers and response management
DataModule.kt Registers Gson type adapters for polymorphic BridgeMessage deserialization
WebViewActionHandlersTest.kt Unit tests for synchronous and asynchronous action handlers
BridgeMessageValidatorTest.kt Unit tests for bridge message validation logic
kmp-common-sdk Updates subproject commit reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@enotniy enotniy force-pushed the feature/MOBILEWEBVIEW-6 branch from 77c48ab to 49bbb80 Compare February 3, 2026 08:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@enotniy enotniy force-pushed the feature/MOBILEWEBVIEW-6 branch from 49bbb80 to 0473969 Compare February 3, 2026 09:15
@enotniy enotniy merged commit 933cf11 into mission/webview-inapp Feb 3, 2026
5 checks passed
@enotniy enotniy deleted the feature/MOBILEWEBVIEW-6 branch February 3, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants